tkinter extra window

[oliver]

Hi
In tkinter i have have written a code which creates a login page for my robot controller application but it comes up with an extra window named tk #2. I get my normal login window and then when i login it opens my robot controller application and closes the login page but the other tk #2 window is still there why would this be and is there a way to stop it happening as i would like a bug free software i could run over VNC on a IPad or laptop.

Code: Select all

from Tkinter import *

def login():
    if u.get() == 'p' and p.get() == 'p':
        print 'your logged in'
        root = Tk()
        root.title('Robot Controller')
        top.destroy()
        root.mainloop()
    else:
        passwordincorrect = Label(root, text='Password incorrect please try again', bg='yellow', fg='red')
        passwordincorrect.pack()


#create window
top=Toplevel()

top.title('Login')
top.configure(background='yellow')
#make the username label
username = Label(top, text='Username:', bg='yellow')
username.pack()
#make the username entry widget
u = Entry(top)
u.pack()
#make the password label
password = Label(top, text='Password:', bg='yellow')
password.pack()
#make the password entry widget
p = Entry(top)
p.pack()
#make the login button
login = Button(top, text='Login:', command=login, fg='white', bg='red')
login.pack()

top.mainloop()

thanks in advance,
Olly

[scotty101]

Single line of code fix

Code: Select all

from Tkinter import *

def login():
    if u.get() == 'p' and p.get() == 'p':
        print 'your logged in'
        root = Tk()
        root.title('Robot Controller')
        top.destroy()
        root.mainloop()
    else:
        passwordincorrect = Label(root, text='Password incorrect please try again', bg='yellow', fg='red')
        passwordincorrect.pack()


#create window
top=Tk()

top.title('Login')
top.configure(background='yellow')
#make the username label
username = Label(top, text='Username:', bg='yellow')
username.pack()
#make the username entry widget
u = Entry(top)
u.pack()
#make the password label
password = Label(top, text='Password:', bg='yellow')
password.pack()
#make the password entry widget
p = Entry(top)
p.pack()
#make the login button
login = Button(top, text='Login:', command=login, fg='white', bg='red')
login.pack()

top.mainloop()

[scotty101]

An additional fix to make your code for the incorrect password work

Code: Select all

from Tkinter import *
import tkMessageBox

def login():
    if u.get() == 'p' and p.get() == 'p':
        print 'your logged in'
        root = Tk()
        root.title('Robot Controller')
        top.destroy()
        root.mainloop()
    else:
        tkMessageBox.showwarning("Incorrect Username or Password","You have typed something incorrectly")

#create window
top=Tk()

top.title('Login')
top.configure(background='yellow')
#make the username label
username = Label(top, text='Username:', bg='yellow')
username.pack()
#make the username entry widget
u = Entry(top)
u.pack()
#make the password label
password = Label(top, text='Password:', bg='yellow')
password.pack()
#make the password entry widget
p = Entry(top)
p.pack()
#make the login button
login = Button(top, text='Login:', command=login, fg='white', bg='red')
login.pack()

top.mainloop()

[RaTTuS]

s/your/you're/

[DirkS]

s/your/you're/

[oliver]

thanks, would never have worked out how to do that myself and also the incorrect password thing, i always get the password right so i would never have known

[scotty101]

You are still learning.

It is always good practice to test all all the different decisions in your code and consider what should happen if a user does something incorrectly.

Good luck with your project.