User avatar
Chromatix
Posts: 430
Joined: Mon Jan 02, 2012 7:00 pm
Location: Helsinki

Re: Kernel Patches

Sat Jan 21, 2012 10:41 pm

I extracted the patches from the Git repo, and uploaded them to the Wiki:

http://elinux.org/Rpi_Software#Kernel

In other news, the Wiki sucks almost as much as the forum software.  Attempting to upload a .tar.xz, a .patch.gz or even a .tar.gz failed due to "Prohibited File Type".  Uploading a .tgz - which is exactly the same as a .tar.gz - worked.
The key to knowledge is not to rely on people to teach you it.


Bitbrit
Posts: 4
Joined: Sat Jan 21, 2012 11:06 pm

Re: Kernel Patches

Sat Jan 21, 2012 11:10 pm

pepedog said:


Is this real?
https://github.com/raspberrypi/linux


That Github repo is linked to on the Raspberry Pi homepage by Liz, so yes it is real.

pepedog
Posts: 1043
Joined: Fri Oct 07, 2011 9:55 am

Re: Kernel Patches

Sat Jan 21, 2012 11:42 pm

I should have looked there first.

Will give it a bash tommorow, or maybe Moday

pepedog
Posts: 1043
Joined: Fri Oct 07, 2011 9:55 am

Re: Kernel Patches

Sun Jan 22, 2012 12:08 pm

Is there any way to speak to Dom, I don't know his username

Edit with more info-

I assume make bcmrpi_cutdown_defconfig is run, and after make modules uImage run imagetool-uncompressed.py, but can't boot from it.

Is "CONFIG_MMC_BCM2708 is not set" really required to be =y?

I tried and got errors

pepedog
Posts: 1043
Joined: Fri Oct 07, 2011 9:55 am

Re: Kernel Patches

Mon Jan 23, 2012 11:30 pm

I wrote to Dom.

Update, now booting from new kernel, it requires a new GPU boot blob called start.elf

Note that drive activity light no longer flickers, and reboot actually reboots.

AlanCox
Posts: 31
Joined: Thu Nov 10, 2011 7:11 pm

Re: Kernel Patches

Tue Jan 24, 2012 10:40 pm

Where should I start sending review comments and bug reports from code review ?

Alan

Bitbrit
Posts: 4
Joined: Sat Jan 21, 2012 11:06 pm

Re: Kernel Patches

Tue Jan 24, 2012 10:56 pm

Hi Alan Cox,

While I am not certain there is an official procedure for reporting bugs yet, the best bet would be to submit a ticket to the "issues" section of the Raspberry Pi Github site. You can find this here: https://github.com/raspberrypi/linux/issues.

AlanCox
Posts: 31
Joined: Thu Nov 10, 2011 7:11 pm

Re: Kernel Patches

Tue Jan 24, 2012 11:40 pm

Not sure that'll work too well - there are rather a lot of "issues".

No offence intended to the developers btw - its in a lot better nick than some of the stuff people actually try submitting.

Can do though if that's the official preferred way to do it.

Alan

jamesh
Raspberry Pi Engineer & Forum Moderator
Raspberry Pi Engineer & Forum Moderator
Posts: 24971
Joined: Sat Jul 30, 2011 7:41 pm

Re: Kernel Patches

Tue Jan 24, 2012 11:45 pm

It's still pretty early development wise, so not really surprising, and of course, all the code was originally intended for embedded systems so wouldn't usually see the light of day, so probably lacks in 'kernel coding standards' (which suck anyway - well the curly bracket usage does - K&R have a lot to answer for). There isn't an official channel yet, try the git route to start with.
Principal Software Engineer at Raspberry Pi (Trading) Ltd.
Contrary to popular belief, humorous signatures are allowed. Here's an example...
“I own the world’s worst thesaurus. Not only is it awful, it’s awful."

Benedict White
Posts: 224
Joined: Sat Dec 24, 2011 12:24 am

Re: Kernel Patches

Tue Jan 24, 2012 11:57 pm

JamesH said:


It's still pretty early development wise, so not really surprising, and of course, all the code was originally intended for embedded systems so wouldn't usually see the light of day, so probably lacks in 'kernel coding standards' (which suck anyway - well the curly bracket usage does - K&R have a lot to answer for). There isn't an official channel yet, try the git route to start with.


Yeh, go pick a fight with all the kernel devs.. great plan to make friends and influence people!

Things are progressing and kernels are looking a bit issue-less at the moment.

How kernels are patched will depend on distribution.

terual
Posts: 7
Joined: Mon Jan 30, 2012 8:10 am

Re: Kernel Patches

Tue Jan 31, 2012 7:21 pm

JamesH said:


all the code was originally intended for embedded systems so wouldn't usually see the light of day, so probably lacks in 'kernel coding standards'


I am no GPL expert whatsoever, but all the kernel bits that have been opened up last week, shouldn't they already have been opened up when they were used in those embedded devices?

JamesH: Is there any ambition in upstreaming those opened up bits, especially as Alan Cox is reviewing your code and all?

kasperl
Posts: 90
Joined: Fri Jan 06, 2012 6:20 pm

Re: Kernel Patches

Tue Jan 31, 2012 7:27 pm

terual said:


JamesH said:


all the code was originally intended for embedded systems so wouldn't usually see the light of day, so probably lacks in 'kernel coding standards'


I am no GPL expert whatsoever, but all the kernel bits that have been opened up last week, shouldn't they already have been opened up when they were used in those embedded devices?


Only when those devices were sold and the consumer asked for it.

dom
Raspberry Pi Engineer & Forum Moderator
Raspberry Pi Engineer & Forum Moderator
Posts: 5398
Joined: Wed Aug 17, 2011 7:41 pm
Location: Cambridge

Re: Kernel Patches

Tue Jan 31, 2012 8:00 pm

We"d love our kernel patches to be upstreamed.
None of us have experience in this, so we"re looking for community help.

Return to “General discussion”