pcmanbob
Posts: 6693
Joined: Fri May 31, 2013 9:28 pm
Location: Mansfield UK

Re: NEW FORUM SKIN - Comments here please.

Tue Jul 25, 2017 3:38 pm

I don't like the new skin it looks to busy.
and I have already ground the the code tags don't work properly, just looked at one of my posts and the code box created by code tags is just a jumble of letters totally unreadable.
example

Code: Select all

#!/bin/bash # Daily Email Script Broadband Monitor v2.00 21 may 2017 # put eamil address in line below email_addresses1="my [email protected]" email_addresses2="some [email protected]" current_time=$(date "+%Y.%m.%d") python /home/pi/makecsv.py python /home/pi/makemessage.py mv /home/pi/speed-test-results.csv /home/pi/$current_time-speed-test-results.csv mv /home/pi/speed_test_results.txt /home/pi/$current_time-speed-test-results.txt mv /home/pi/connection-results.csv /home/pi/$current_time-connection-results.csv echo "Quality %,Test Time,Failed Site Name" > /home/pi/connection-results.csv cd /home/pi zip $current_time-results.zip $current_time-speed-test-results.csv $current_time-speed-test-results.txt $current_time-connection-results.csv cd mpack -s "Broadband Monitor Results with zip file attached" -d /home/pi/message.txt /home/pi/$current_time-results.zip $email_addresses1 mpack -s "Broadband Monitor Results with zip file attached" -d /home/pi/message.txt /home/pi/$current_time-results.zip $email_addresses2 mv /home/pi/$current_time-speed-test-results.txt /home/pi/archive/ mv /home/pi/$current_time-speed-test-results.csv /home/pi/archive/ mv /home/pi/$current_time-connection-results.csv /home/pi/archive/ rm /home/pi/message.txt rm /home/pi/$current_time-results.zip 
so posting code is now a total waste of time on this forum.

The font is way to big, yes I were glasses but I am not blind yet.

and it does not work on my 9" table any more columns are just overlapping each other making it impossible to read.

If this skin persists I think this forum will just die as it unusable.

Edit.
switching to rpi skin has at least reduced the font size.
but code tags still don't work.
Last edited by pcmanbob on Tue Jul 25, 2017 3:45 pm, edited 1 time in total.
We want information… information… information........................no information no help
The use of crystal balls & mind reading are not supported

User avatar
DougieLawson
Posts: 35838
Joined: Sun Jun 16, 2013 11:19 pm
Location: Basingstoke, UK
Contact: Website Twitter

Re: NEW FORUM SKIN - Comments here please.

Tue Jul 25, 2017 3:44 pm

I've switched to RPI. It's like Prosilver but without the ugly blueness. That's going to work for me.
The default "Raspberry_Pi" is exceedingly ugly compared to RPI.
Note: Having anything humorous in your signature is completely banned on this forum. Wear a tin-foil hat and you'll get a ban.

Any DMs sent on Twitter will be answered next month.

This is a doctor free zone.

beta-tester
Posts: 1236
Joined: Fri Jan 04, 2013 1:57 pm
Location: de_DE

Re: NEW FORUM SKIN - Comments here please.

Tue Jul 25, 2017 3:47 pm

pcmanbob wrote:
Tue Jul 25, 2017 3:38 pm
I don't like the new skin it looks to busy.
and I have already ground the the code tags don't work properly, just looked at one of my posts and the code box created by code tags is just a jumble of letters totally unreadable.
example

Code: Select all

#!/bin/bash # Daily Email Script Broadband Monitor v2.00 21 may 2017 # put eamil address in line below email_addresses1="my [email protected]" email_addresses2="some [email protected]" current_time=$(date "+%Y.%m.%d") python /home/pi/makecsv.py python /home/pi/makemessage.py mv /home/pi/speed-test-results.csv /home/pi/$current_time-speed-test-results.csv mv /home/pi/speed_test_results.txt /home/pi/$current_time-speed-test-results.txt mv /home/pi/connection-results.csv /home/pi/$current_time-connection-results.csv echo "Quality %,Test Time,Failed Site Name" > /home/pi/connection-results.csv cd /home/pi zip $current_time-results.zip $current_time-speed-test-results.csv $current_time-speed-test-results.txt $current_time-connection-results.csv cd mpack -s "Broadband Monitor Results with zip file attached" -d /home/pi/message.txt /home/pi/$current_time-results.zip $email_addresses1 mpack -s "Broadband Monitor Results with zip file attached" -d /home/pi/message.txt /home/pi/$current_time-results.zip $email_addresses2 mv /home/pi/$current_time-speed-test-results.txt /home/pi/archive/ mv /home/pi/$current_time-speed-test-results.csv /home/pi/archive/ mv /home/pi/$current_time-connection-results.csv /home/pi/archive/ rm /home/pi/message.txt rm /home/pi/$current_time-results.zip 
so posting code is now a total waste of time on this forum.
your code appears as one-liner.
what theme you used?

code block created with theme prosilver looks ok to me.

Code: Select all

# 1'st line
# 2'nd line
# 3'rd line
# 4'th line
# 5'th line
# 6'th line
# 7'th line
# 8'th line
# 9'th line
...
Last edited by beta-tester on Tue Jul 25, 2017 3:50 pm, edited 1 time in total.
{ I only give negative feedback }
RPi Model B (rev1, 256MB) & B (rev2, 512MB) & B+, RPi2B, RPi3B, RPi3B+, RPiZeroW, ...

pcmanbob
Posts: 6693
Joined: Fri May 31, 2013 9:28 pm
Location: Mansfield UK

Re: NEW FORUM SKIN - Comments here please.

Tue Jul 25, 2017 3:47 pm

DougieLawson wrote:
Tue Jul 25, 2017 3:44 pm
I've switched to RPI. It's like Prosilver but without the ugly blueness. That's going to work for me.
The default "Raspberry_Pi" is exceedingly ugly compared to RPI.
I agree RPI is the best of the 3 poor options but without working code tags forum is going to struggle.
We want information… information… information........................no information no help
The use of crystal balls & mind reading are not supported

beta-tester
Posts: 1236
Joined: Fri Jan 04, 2013 1:57 pm
Location: de_DE

Re: NEW FORUM SKIN - Comments here please.

Tue Jul 25, 2017 3:53 pm

pcmanbob wrote:
Tue Jul 25, 2017 3:47 pm
DougieLawson wrote:
Tue Jul 25, 2017 3:44 pm
I've switched to RPI. It's like Prosilver but without the ugly blueness. That's going to work for me.
The default "Raspberry_Pi" is exceedingly ugly compared to RPI.
I agree RPI is the best of the 3 poor options but without working code tags forum is going to struggle.
so the code block is only in theme RPI an issue.
what i don't like on theme RPI is the big spacings everywhere and the dark gray background while writing/editing a post.
Last edited by beta-tester on Tue Jul 25, 2017 3:56 pm, edited 1 time in total.
{ I only give negative feedback }
RPi Model B (rev1, 256MB) & B (rev2, 512MB) & B+, RPi2B, RPi3B, RPi3B+, RPiZeroW, ...

User avatar
mahjongg
Forum Moderator
Forum Moderator
Posts: 12131
Joined: Sun Mar 11, 2012 12:19 am
Location: South Holland, The Netherlands

Re: NEW FORUM SKIN - Comments here please.

Tue Jul 25, 2017 3:56 pm

Let me try posting code:

Code: Select all

def ReadWatts(ser):
     global xwatts, old_xwatts, maxwatts, start_time

        xwatts = round(float(rtwatts) * 3 / 1000, 1) # you can do this like this!
        if xwatts >= maxwatts and old_xwatts < maxwatts:
            start_time = time.time()
        if xwatts < maxwatts:
            start_time = time.time() + 10000.0 # well in the future, just to be on the safe side!
        old_xwatts = xwatts
     return xwatts
     print xwatts # you can't get to anything after the return in a function

# inside the main loop
    if (time.time() - start_time) > 5.0:
        do_5s_function()
        start_time += 10000.0 # to stop repeating every loop

User avatar
DougieLawson
Posts: 35838
Joined: Sun Jun 16, 2013 11:19 pm
Location: Basingstoke, UK
Contact: Website Twitter

Re: NEW FORUM SKIN - Comments here please.

Tue Jul 25, 2017 3:56 pm

I've found the "Unread Posts" link. So I'm now 100% happy with the RPI skin and will stick with that.

Code: Select all

#!bin/bash
echo "Do code blocks work?
Looks like code blocks don't work (in a nice pretty green text) on the RPI theme. Something lost the line-ends.
Note: Having anything humorous in your signature is completely banned on this forum. Wear a tin-foil hat and you'll get a ban.

Any DMs sent on Twitter will be answered next month.

This is a doctor free zone.

User avatar
mahjongg
Forum Moderator
Forum Moderator
Posts: 12131
Joined: Sun Mar 11, 2012 12:19 am
Location: South Holland, The Netherlands

Re: NEW FORUM SKIN - Comments here please.

Tue Jul 25, 2017 3:57 pm

Nope you are right it doesn't work the way it should!
the people working on this skin should repair this ASAP.

[edit] well, what do you know, its fixed already!

pcmanbob
Posts: 6693
Joined: Fri May 31, 2013 9:28 pm
Location: Mansfield UK

Re: NEW FORUM SKIN - Comments here please.

Tue Jul 25, 2017 4:00 pm

Posting this using RPI skin.

some example code with no code tags copied from notepad++ as I normally do displays as list of lines but looses all the indenting as it always has


GPIO.setmode(GPIO.BOARD)
GPIO.setwarnings(False)
GPIO.setup(38, GPIO.IN)

# main loop

while True:
# wait for button press
while GPIO.input(38) == 0:
time.sleep(0.2)
else:

# get IP address from eth0

ni.ifaddresses('eth0')
ip = ni.ifaddresses('eth0')[2][0]['addr']
iptext = str(ip)


# write IP on LCD

lcd = CharLCD()
lcd.clear()
lcd.cursor_pos = (0, 0)
lcd.write_string('Broadband Monitor Pi')
lcd.cursor_pos = (1, 3)
lcd.write_string('My IP for eth0')
lcd.cursor_pos = (3, 3)
lcd.write_string(iptext)
time.sleep(10)

now placed between code tags coped exactly the same (used to display as list of lines with correct indenting) but no longer

Code: Select all

GPIO.setmode(GPIO.BOARD)
GPIO.setwarnings(False)
GPIO.setup(38, GPIO.IN)

# main loop

while True:
	# wait for button press
	while GPIO.input(38) == 0:
		time.sleep(0.2)
	else:
		
		# get IP address from eth0

		ni.ifaddresses('eth0')
		ip = ni.ifaddresses('eth0')[2][0]['addr']
		iptext = str(ip)


		# write IP on LCD

		lcd = CharLCD()
		lcd.clear()
		lcd.cursor_pos = (0, 0)
		lcd.write_string('Broadband Monitor Pi')
		lcd.cursor_pos = (1, 3)
		lcd.write_string('My IP for eth0')
		lcd.cursor_pos = (3, 3)
		lcd.write_string(iptext)
		time.sleep(10)
We want information… information… information........................no information no help
The use of crystal balls & mind reading are not supported

User avatar
mahjongg
Forum Moderator
Forum Moderator
Posts: 12131
Joined: Sun Mar 11, 2012 12:19 am
Location: South Holland, The Netherlands

Re: NEW FORUM SKIN - Comments here please.

Tue Jul 25, 2017 4:02 pm

It seems to be a raspberry_pi skin display problem, as the standard pro silver skin works.
Will alarm the people responsible immediately, so hopefully it will be fixed soon.
its a pity we didn't notice this behaviour in the test stage.
stupid teething troubles.... :mrgreen:

pcmanbob
Posts: 6693
Joined: Fri May 31, 2013 9:28 pm
Location: Mansfield UK

Re: NEW FORUM SKIN - Comments here please.

Tue Jul 25, 2017 4:04 pm

mahjongg wrote:
Tue Jul 25, 2017 4:02 pm
It seems to be a raspberry_pi skin display problem, as the standard pro silver skin works.

It affects raspberry_pi and RPI skins not tried pro silver skin yet.
Last edited by pcmanbob on Tue Jul 25, 2017 4:04 pm, edited 1 time in total.
We want information… information… information........................no information no help
The use of crystal balls & mind reading are not supported

beta-tester
Posts: 1236
Joined: Fri Jan 04, 2013 1:57 pm
Location: de_DE

Re: NEW FORUM SKIN - Comments here please.

Tue Jul 25, 2017 4:04 pm

mahjongg wrote:
Tue Jul 25, 2017 4:02 pm
It seems to be a raspberry_pi skin display problem, as the standard pro silver skin works.
"RPI" has problems as well.
"ProSilver" is fine - no problems
{ I only give negative feedback }
RPi Model B (rev1, 256MB) & B (rev2, 512MB) & B+, RPi2B, RPi3B, RPi3B+, RPiZeroW, ...

beta-tester
Posts: 1236
Joined: Fri Jan 04, 2013 1:57 pm
Location: de_DE

Re: NEW FORUM SKIN - Comments here please.

Tue Jul 25, 2017 4:10 pm

mahjongg wrote:
Tue Jul 25, 2017 4:02 pm
its a pity we didn't notice this behaviour in the test stage.
stupid teething troubles.... :mrgreen:
that means nobody of the testers were using the other themes except prosilver for serious posts... :lol:
{ I only give negative feedback }
RPi Model B (rev1, 256MB) & B (rev2, 512MB) & B+, RPi2B, RPi3B, RPi3B+, RPiZeroW, ...

User avatar
bensimmo
Posts: 4162
Joined: Sun Dec 28, 2014 3:02 pm
Location: East Yorkshire

Re: NEW FORUM SKIN - Comments here please.

Tue Jul 25, 2017 4:15 pm

RPI is the nicer skin to use on my mobile. Boy's are not cut off.

The raspberry skin seems to work ok in landscape but the default mobile mobile portrait is messy.

RPI has the same code problem
RPI has the same save draft, preview, sumbit button glitch


We still need a larger image attachment as a simple screen grab on my phone to show the problems cannot be attached quickly.

User avatar
mahjongg
Forum Moderator
Forum Moderator
Posts: 12131
Joined: Sun Mar 11, 2012 12:19 am
Location: South Holland, The Netherlands

Re: NEW FORUM SKIN - Comments here please.

Tue Jul 25, 2017 4:17 pm

Well, I did some preliminary tests with the new theme, and I did notice that sticky posts were initially displayed the exact same way as all other posts, (and so were unrecognisable as stickies) so I edited all sticky post subject lines to prefix them with STICKY: hoping a better solution would arrive later. And I remember having looked at some python posts but saw nothing suspicious, but I could have just missed it.
I did NOT try to post any code, unfortunately.
lets hope this can be fixed quickly.

jamesh
Raspberry Pi Engineer & Forum Moderator
Raspberry Pi Engineer & Forum Moderator
Posts: 23405
Joined: Sat Jul 30, 2011 7:41 pm

Re: NEW FORUM SKIN - Comments here please.

Tue Jul 25, 2017 4:18 pm

beta-tester wrote:
Tue Jul 25, 2017 4:10 pm
mahjongg wrote:
Tue Jul 25, 2017 4:02 pm
its a pity we didn't notice this behaviour in the test stage.
stupid teething troubles.... :mrgreen:
that means nobody of the testers were using the other themes except prosilver for serious posts... :lol:
I helped test, never saw the code problem though. My bad. And no, I didn't just test in prosilver since that a PHPBB supplied skin and therefor well tested elsewhere.
Principal Software Engineer at Raspberry Pi (Trading) Ltd.
Contrary to popular belief, humorous signatures are allowed. Here's an example...
"My grief counseller just died, luckily, he was so good, I didn't care."

User avatar
bensimmo
Posts: 4162
Joined: Sun Dec 28, 2014 3:02 pm
Location: East Yorkshire

Re: NEW FORUM SKIN - Comments here please.

Tue Jul 25, 2017 4:19 pm

Oh and thanks for doing all of this, it should benefit everyone in the end :-D

jamesh
Raspberry Pi Engineer & Forum Moderator
Raspberry Pi Engineer & Forum Moderator
Posts: 23405
Joined: Sat Jul 30, 2011 7:41 pm

Re: NEW FORUM SKIN - Comments here please.

Tue Jul 25, 2017 4:20 pm

The white box/unsolicited drop down appearing in the RPI skin should now be fixed.
Principal Software Engineer at Raspberry Pi (Trading) Ltd.
Contrary to popular belief, humorous signatures are allowed. Here's an example...
"My grief counseller just died, luckily, he was so good, I didn't care."

User avatar
mahjongg
Forum Moderator
Forum Moderator
Posts: 12131
Joined: Sun Mar 11, 2012 12:19 am
Location: South Holland, The Netherlands

Re: NEW FORUM SKIN - Comments here please.

Tue Jul 25, 2017 4:27 pm

jamesh wrote:
Tue Jul 25, 2017 4:20 pm
The white box/unsolicited drop down appearing in the RPI skin should now be fixed.
Yes, I noticed it before, but its gone now.

What IS the "RPI skin"? is it just an experimental alternative skin?

User avatar
bensimmo
Posts: 4162
Joined: Sun Dec 28, 2014 3:02 pm
Location: East Yorkshire

Re: NEW FORUM SKIN - Comments here please.

Tue Jul 25, 2017 4:29 pm

RPI skin
Landscape there is a jump to new posts click bit (icon could be larger)
Move to Portrait and it's not there.

drgeoff
Posts: 9763
Joined: Wed Jan 25, 2012 6:39 pm

Re: NEW FORUM SKIN - Comments here please.

Tue Jul 25, 2017 4:31 pm

On the default theme:

I miss the 'Return to xxxx' button and the 'Jump to' drop down selection.

The reddy-brown colour is garish. The font is too large.

Permalink button is gone.

jamesh
Raspberry Pi Engineer & Forum Moderator
Raspberry Pi Engineer & Forum Moderator
Posts: 23405
Joined: Sat Jul 30, 2011 7:41 pm

Re: NEW FORUM SKIN - Comments here please.

Tue Jul 25, 2017 4:42 pm

mahjongg wrote:
Tue Jul 25, 2017 4:27 pm
jamesh wrote:
Tue Jul 25, 2017 4:20 pm
The white box/unsolicited drop down appearing in the RPI skin should now be fixed.
Yes, I noticed it before, but its gone now.

What IS the "RPI skin"? is it just an experimental alternative skin?
Will be the 'final' version of forum I believe - currently being developed, so not ready to replace anything yet, but needs testing. Things should go a lot faster now the new PHPBB software is in place.
Principal Software Engineer at Raspberry Pi (Trading) Ltd.
Contrary to popular belief, humorous signatures are allowed. Here's an example...
"My grief counseller just died, luckily, he was so good, I didn't care."

jamesh
Raspberry Pi Engineer & Forum Moderator
Raspberry Pi Engineer & Forum Moderator
Posts: 23405
Joined: Sat Jul 30, 2011 7:41 pm

Re: STICKY: NEW FORUM SKIN - Comments here please.

Tue Jul 25, 2017 4:45 pm

I think the RPI skin code blocks should now be working, not sure about raspberry yet, but worth a try.

EDIT. Should be fixed in both themes.
Principal Software Engineer at Raspberry Pi (Trading) Ltd.
Contrary to popular belief, humorous signatures are allowed. Here's an example...
"My grief counseller just died, luckily, he was so good, I didn't care."

DirkS
Posts: 9902
Joined: Tue Jun 19, 2012 9:46 pm
Location: Essex, UK

Re: STICKY: NEW FORUM SKIN - Comments here please.

Tue Jul 25, 2017 4:49 pm

jamesh wrote:
Tue Jul 25, 2017 4:45 pm
I think the RPI skin code blocks should now be working, not sure about raspberry yet, but worth a try.

EDIT. Should be fixed in both themes.

Code: Select all

dfjdfjdfjdfj
adf 
df adf  
Yes, seems to be working in RPI

jamesh
Raspberry Pi Engineer & Forum Moderator
Raspberry Pi Engineer & Forum Moderator
Posts: 23405
Joined: Sat Jul 30, 2011 7:41 pm

Re: STICKY: NEW FORUM SKIN - Comments here please.

Tue Jul 25, 2017 4:50 pm

jamesh wrote:
Tue Jul 25, 2017 4:45 pm
I think the RPI skin code blocks should now be working, not sure about raspberry yet, but worth a try.

EDIT. Should be fixed in both themes.
Yes, checked it, working fine now. Thanks Web Dudes!
Principal Software Engineer at Raspberry Pi (Trading) Ltd.
Contrary to popular belief, humorous signatures are allowed. Here's an example...
"My grief counseller just died, luckily, he was so good, I didn't care."

Return to “General discussion”